feat: allow customizing css filter and establish modified defaults #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssylvia
requested changes
May 7, 2024
Changes to expose the `arcgisCSSWhiteList` as a public readonly property to allow users to get our defaults as well as use them as a base to modify. Eliminated unnecessary code and expanded the tests for this refactor.
|
@ssylvia Thanks for the great suggestions. I've exposed the ArcGIS defaults as |
ssylvia
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default CSS filter to turn on
overflow,line-heightand the flexbox options:flex,flex-basis,flex-direction,flex-flow,flex-grow,flex-shrink,flex-wrap.Also added code to ensure that overriding or extending default css whiteList takes our defaults into account. Added tests to ensure that extending defaults and overriding work as intended, as well as to test out the CSS properties enabled by default.