-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive panel-based UI #99
Conversation
Note: need to figure out why template is being ignored on UWP
…ion-dotnet into ncastle/panel-based-ui # Conflicts: # src/ControlsTestWPF/MainWindow.xaml
Improved appearance of card icons, attribution; added attribution popup viewer; Fixed window maximize behavior by adding controlzEx and using window behaviors from Fluent.Ribbon project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nCastle1 I think we're nearly there with this latest submission. I'm approving this PR with the assumption that the sole bug is addressed (or acknowledged). Congrats, this project is huge!
I've divided this review into two sections. The first, Bugs, is a slight misrepresentation because i've found only one bug that hasn't already been raised- and i'm not entirely sure it's a bug.
The second, Platform Parity, is a section devoted to requests i'm making that bring the application in its current state to parity with other Data Collection apps. It's very important to emphasize here that these suggestions are not coupled to this PR. However, they are a requirement for the release of v1.3. As such if you feel as though they can be addressed at a later time, please feel free to extract them from this review into their own issues. Also, i'd be happy to expand on these requirements if anything is unclear or you're needed a more rigid spec req, please just ask.
Bugs
Species Related Record Odd Behavior
I'm experiencing odd behavior when editing the Species related record. When editing the Tree record, after selecting a new Species from the drop down and before saving the Tree record, the Species 'field' becomes wildly scrollable. This probably doesn't make sense, here are steps to repro:
- Identify Tree
- Start editing session
- Click species field dropdown
- Select new species
- Hover mouse over species field (but don't click)
- Use scroll wheel -> the field is scrollable when it shouldn't be
Platform Parity
Sync Offline Map When Online
Previously, I chose not to raise this platform disparity but i'd like to raise this requirement now.
I'd like to see the Profile view resemble in form and in function (with modifications made for desktop) to that of the iOS application and as it is specified. The reason why this specified design is an improvement to what is here (IMO) is because a user might want to synchronize or delete an offline map when they are operating in online work mode. Currently, a user much switch into offline mode in order to sync or delete the offline map. This presents an undue UX hurdle.
What this means WRT the design spec is that this view incoroprate items 5-8 and they adhere to the same layout and operate similarly (identical?) to how they operate in the iOS app.
Working Online, No Offline Map | Working Online, Has Offline Map | Working Offline |
---|---|---|
This feature in its current form is acceptable because it solves the problem but I think there's room for improvement here and an opportunity to increase parity from platform to platform. If you think it better, we can extract this requirement from this PR and place it into its own issue. Do let me know what you want to do here, I can go either way.
Coordinate Portal Profile Info
There is a disparity in what Portal User information is displayed in the Profile view. Specifically, the iOS application displays the user's email and the .Net application displays the user's username. ArcGIS Collector aligns with .Net on this one. What do you think Data Collection should do?
For me what is most important is that there is parity.
iOS | .Net |
---|---|
Portal Profile Info Runtime Metadata
Currently the iOS and Android apps support displaying App & Runtime metadata, It appears the .Net app does not. Can we get this metadata added to the Profile view? In iOS, this information is derived by looking up information stored in the app's Bundle
(not hardcoded).
I'm thinking this information would convey well just beneath the Sign In/ Sign Out button of the login pane.
Again, this request is inconsequential WRT this PR, if you find it more appropriate to do so we can move this request to a new issue.
# Conflicts: # RELEASE.md # src/DataCollection.WPF/DataCollection.WPF (.NET Core).csproj
I've filed #103 and #104 to address feedback that is outside the scope of this PR. The other bug mentioned, about combobox scrolling, is actually how the built-in control is expected to behave. It can cause problems under parallels, due to inconsistencies between how macOS and Windows handle scrolling, especially with trackpads. I verified that the current behavior matches native UWP apps and ArcGIS Pro. |
Sounds good, we'll prioritize these at a later date. If the base branch is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I caught a few things and already spoke with Nathan about them, so I'll push up some commits which address them in a few moments.
Biggest thing that I'm undecided on is whether this release warrants a step up in the minor version and not just a patch.
RELEASE.md
Outdated
## 1.2.4 | ||
|
||
* Updates both WPF and UWP with a new design that adapts to work well for any screen size. | ||
* Adds a `ModernMapPanel` custom layout panel to facilitate consistent, responsive design for UWP and WPF. | ||
* Refactors styles and related XAML. | ||
* Switches to vector icons where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates Data Collection with a new panel-based UI and a modified design for both UWP and WPF.