Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rollup-plugin-json with @rollup/plugin-json #248

Closed
gavinr opened this issue May 21, 2020 · 5 comments
Closed

Replace rollup-plugin-json with @rollup/plugin-json #248

gavinr opened this issue May 21, 2020 · 5 comments

Comments

@gavinr
Copy link
Contributor

gavinr commented May 21, 2020

When running npm install, I get an error:

[!] Error: Cannot find module '@rollup/plugin-json'
Require stack:
- ....\esri-leaflet-geocoder\profiles\debug.js
- ....\esri-leaflet-geocoder\node_modules\rollup\bin\rollup
Error: Cannot find module '@rollup/plugin-json'
Require stack:
- ....\esri-leaflet-geocoder\profiles\debug.js
- ....\esri-leaflet-geocoder\node_modules\rollup\bin\rollup
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:982:15)
    at Function.Module._load (internal/modules/cjs/loader.js:864:27)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (....\esri-leaflet-geocoder\profiles\debug.js:5:28)
    at Module._compile (internal/modules/cjs/loader.js:1158:30)
    at Object.require.extensions..js (....\esri-leaflet-geocoder\node_modules\rollup\bin\rollup:2799:19)
    at Module.load (internal/modules/cjs/loader.js:1002:32)
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
@jgravois
Copy link
Contributor

the perils of relying on the build profile in esri-leaflet itself. 😄

import config from '../node_modules/esri-leaflet/profiles/base.js';

@gavinr
Copy link
Contributor Author

gavinr commented May 21, 2020

Ah, so you're saying since we're relying on that, and we just switched esri-leaflet to the newer plugin (https://github.com/Esri/esri-leaflet/pull/1201/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R36) we'll need to make similar updates here? 👍

@jgravois
Copy link
Contributor

yeah.

sometimes having a DRY rollup setup saves us from making the same change in more than one plugin, other times it has the opposite effect. 😬

@gavinr gavinr mentioned this issue May 21, 2020
@jwasilgeo
Copy link
Contributor

Closed via PR #249.

@gavinr
Copy link
Contributor Author

gavinr commented May 29, 2020

This was released in v2.3.3

gavinr pushed a commit to gavinr/esri-leaflet-renderers that referenced this issue Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants