Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

use map variable passed to onAdd function as the map in metadata funciton #27

Merged
merged 1 commit into from
Mar 2, 2015
Merged

Conversation

kneemer
Copy link
Contributor

@kneemer kneemer commented Mar 2, 2015

Resolves #26

The map in the metadata function is a little ambiguous and when using Browserify it refers to the map container not the map object.

The map in the onAdd function is passed in as the proper map object when using Browserify so use it instead.

@jgravois
Copy link
Contributor

jgravois commented Mar 2, 2015

all grunt tests passed, but this caused errors fetching picture marker symbols for me when running debug/sample.html and the code snippet in the readme until i added this

this._setRenderers = function(geojson){
    ...
    options = {url: this._service.options.url};

@kneemer
Copy link
Contributor Author

kneemer commented Mar 2, 2015

This is only the case with the new change?

You had to change
options = {url: this.url};
to the above?

@kneemer
Copy link
Contributor Author

kneemer commented Mar 2, 2015

I wasn't able to reproduce your error at first but I was using esri-leaflet RC 4. Once I switched to RC 5, I saw the error. I see the error when I roll back this change so it should probably be a separate issue.

Related to the breaking change: Esri/esri-leaflet#420

@jgravois
Copy link
Contributor

jgravois commented Mar 2, 2015

💡

jgravois added a commit that referenced this pull request Mar 2, 2015
use map variable passed to onAdd function as the map in metadata funciton
@jgravois jgravois merged commit 1103bd3 into Esri:master Mar 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using Browserify
2 participants