Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L.esri is undefined while zooming in/out #1191

Closed
danieloliveira117 opened this issue Mar 31, 2020 · 2 comments · Fixed by #1192
Closed

L.esri is undefined while zooming in/out #1191

danieloliveira117 opened this issue Mar 31, 2020 · 2 comments · Fixed by #1192

Comments

@danieloliveira117
Copy link
Contributor

danieloliveira117 commented Mar 31, 2020 •
edited
Loading

I'm using esri-leaflet as an import (webpack) instead extending the global L.

When zooming in or out I'm getting the error:
TypeError: L.esri is undefined

The error is in the following line:

esri-leaflet/src/Layers/BasemapLayer.js

Line 305 in 6fb1275

L.esri.request(tilemapUrl, {}, function (err, response) {

It should be able to be fixed simply by importing the request function instead of using the global L.esri.
@jgravois
Copy link
Contributor

great catch. a pull request with a fix would be most welcome.

@danieloliveira117 danieloliveira117 mentioned this issue Mar 31, 2020
Merged
jwasilgeo added a commit that referenced this issue Apr 1, 2020
@jwasilgeo
Merge pull request #1192 from danieloliveira117/master
7e978ed 
Add request as import in `BasemapLayer.js` (#1191)
@gavinr
Copy link
Contributor

gavinr commented Apr 22, 2020

This was released in v2.4.0: https://github.com/Esri/esri-leaflet/releases/tag/v2.4.0

jgravois pushed a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
@danieloliveira117
Add request as import (Esri#1191)
23368f9
jgravois pushed a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
@jwasilgeo
Merge pull request Esri#1192 from danieloliveira117/master
db04940 
Add request as import in `BasemapLayer.js` (Esri#1191)
jgravois pushed a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
@danieloliveira117
Add request as import (Esri#1191)
1511d43
jgravois pushed a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
@jwasilgeo
Merge pull request Esri#1192 from danieloliveira117/master
a0e6fa4 
Add request as import in `BasemapLayer.js` (Esri#1191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add request as import (#1191)
3 participants
@gavinr @jgravois @danieloliveira117