warning with webpack5

[wwwwlm-work]

Describe the bug

not ok when using webpack5.

Expected behavior

should use default export instead of named export

Actual behavior

there comes a warning as blow:
in /node_modules/esri-leaflet/src/EsriLeaflet.js
Should not import the named export 'version' (reexported as 'VERSION') from default-exporting module (only default export is available soon)

To Reproduce

using webpack5

Environment Information

• Version of Leaflet (L.version): 1.7.1
• Version of Esri Leaflet (L.esri.VERSION): 2.5.2
• Your OS: window 10
• Browser and Version Chrome 87.0.4280.88

Additional context

webpack: 5.11.0;

[gavinr]

Thanks for the report - could you please post more specific replication steps?

[jgravois]

@gavinr is right. a dummy application with the bare minimum code needed to reproduce the error would help the maintainers here focus on solving the problem instead of repro-ing the behavior you're reporting.

based on the information @wwwwlm-work already provided, its possible webpack@5 is finding fault with the current mix of named and default exports.

esri-leaflet/src/Request.js

Line 248 in 3473979

export default Request;

The rollup doc confirms that the practice is frowned upon: https://rollupjs.org/guide/en/#default-export

It is bad practice to mix default and named exports in the same module, though it is allowed by the specification.

i haven't given it much thought, but i'd expect the appropriate action to be getting rid of the default exports, not the other way around.

[wwwwlm-work]

here is the demo repo to reproduce : https://github.com/wwwwlm-work/issue-demo

blow is what I did to prevent that warning temporarily:

// current
export {version as VERSION} from '../package.json';

// improved
import pkg from '../package.json'
const VERSION = pkg.version;
export { VERSION };

[Happytoad42]

Any update on this issue?

[daanielcarvalho]

Hello

There is any solution on this?

ERROR in ./node_modules/esri-leaflet/src/EsriLeaflet.js 2:0-51
Should not import the named export 'version' (reexported as 'VERSION') from default-exporting module (only default export is available soon)
 @ ./node_modules/esri-leaflet-geocoder/dist/esri-leaflet-geocoder-debug.js

when compiling webpack 5 get this erros, and this package is a dependency of other packages, forking it's not a solution.´

Thanks
Daniel

[gavinr]

PRs welcome, I would suggest along the lines of @jgravois's suggestion:

i haven't given it much thought, but i'd expect the appropriate action to be getting rid of the default exports, not the other way around.

[destus90]

Angular CLI version 12 is now shipped with Webpack 5 under the hood by default. So it gives us an error (not a warning) when using esri-leaflet in a such project :(

I pushed a PR that should fix this.

// @gavinr @jgravois

[gavinr]

the fix from @destus90 was released in v3.0.2