-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use default export from package instead of named export version #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destus90
force-pushed
the
webpack5-warning
branch
from
May 24, 2021 13:27
a2802b6
to
9c6e73d
Compare
gavinr
approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me - thanks for the PR!
jwasilgeo
approved these changes
May 24, 2021
released in v3.0.2 |
gavinr
pushed a commit
to gavinr/esri-leaflet-heatmap
that referenced
this pull request
Mar 8, 2022
New way to import the JSON file, same change as Esri/esri-leaflet#1273
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
…sri#1273) * fix: Use default export from package instead of named export version * formatting * changelog Co-authored-by: Gavin Rehkemper <[email protected]>
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
…sri#1273) * fix: Use default export from package instead of named export version * formatting * changelog Co-authored-by: Gavin Rehkemper <[email protected]>
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://webpack.js.org/migrate/5/#cleanup-the-code
With this fix allow to use Webpack 5 with no warning emitted.
Fixes #1249