Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the lod value for some zoom level is 0 tiles is not display properly #1380

Closed
mvtm-dn opened this issue Nov 14, 2023 · 3 comments · Fixed by #1381
Closed

When the lod value for some zoom level is 0 tiles is not display properly #1380

mvtm-dn opened this issue Nov 14, 2023 · 3 comments · Fixed by #1381

Comments

@mvtm-dn
Copy link
Contributor

mvtm-dn commented Nov 14, 2023

Describe the bug

According to the wrong condition in the case when this._lodMap[zoom]===0 TiledMapLayer uses zoom instead of 0. And TiledMapLayer tries to load the wrong tiles.

Reproduction

Alas, but problem ArcGIS tiles with level 0 is private and I can't send link

Logs

No response

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
    Memory: 9.11 GB / 31.07 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
    npm: 8.3.1 - ~/.nvm/versions/node/v16.14.0/bin/npm
  Browsers:
    Chrome: 117.0.5938.92
  npmPackages:
    leaflet: ^1.6.0 => 1.6.0 
    esri-leaflet: ^3.0.11 => 3.0.11

Additional Information

No response

mvtm-dn added a commit to mvtm-dn/esri-leaflet that referenced this issue Nov 14, 2023
@gavinr-maps gavinr-maps linked a pull request Nov 14, 2023 that will close this issue
@gavinr-maps
Copy link
Contributor

Thank you for logging this issue. I think I was able to find a public tiled layer that has LOD 0 that I can see this issue on. See the steps below - can you please confirm that this is the issue you're reporting?

Replication case:

  1. Open https://jsbin.com/qafojoc/2/edit?html,output which is zoomed to LOD 1
  2. Click the zoom out button so you're now zoomed to LOD 0
  3. Expected: map tiles/repeats across the view area like this: image
    • Actual: only one tile of the map is seen in the center of the screen, with gray areas to the left/right like this:
      image

@mvtm-dn
Copy link
Contributor Author

mvtm-dn commented Nov 21, 2023

Thank you for logging this issue. I think I was able to find a public tiled layer that has LOD 0 that I can see this issue on. See the steps below - can you please confirm that this is the issue you're reporting?

Replication case:

  1. Open https://jsbin.com/qafojoc/2/edit?html,output which is zoomed to LOD 1

  2. Click the zoom out button so you're now zoomed to LOD 0

  3. Expected: map tiles/repeats across the view area like this: image

    • Actual: only one tile of the map is seen in the center of the screen, with gray areas to the left/right like this:
      image

Looks similar

@gavinr-maps
Copy link
Contributor

Fixed in v3.0.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants