fix logic for determining when to map lods #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theashyster
reviewed
Feb 16, 2018
| @@ -140,7 +140,10 @@ export var TiledMapLayer = TileLayer.extend({ | |||
| } | |||
|
|
|||
| this.fire('lodmap'); | |||
| } else if (map.options.crs && map.options.crs.code && (map.options.crs.code.indexOf(sr) > -1) || (map.options.crs === CRS.EPSG4326 && (sr === 4326))) { | |||
There was a problem hiding this comment.
Hmm, I think the second part is actually redundant here.
I looked at CRS.EPSG4326 here https://github.com/Leaflet/Leaflet/blob/master/src/geo/crs/CRS.EPSG4326.js#L20 and it also contains code attribute, so the code would go in the else if block already after the first check that is map.options.crs && map.options.crs.code && (map.options.crs.code.indexOf(sr) > -1)
So at the end it looks to me that this else if block could be simplified to this
} else if (map.options.crs && map.options.crs.code && map.options.crs.code.indexOf(sr) > -1) {
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
fix logic for determining when to map lods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i made a serious logic error in #1045
we should only be attempting to remap LODs when the CRS of the map is web mercator and the LODs roughly match the convention
for WGS84 tiled services and applications with an appropriately defined custom CRS (using Proj4) that matches the service, we should do nothing.
we should only log a warning to the console when neither of the above are true.
cc/ @theashyster