-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add and update several features in FeatureLayer #1083
Conversation
Though I think it would make more sense to have one single function |
very cool @Biboba. thank you!
that'd be okay with me as long as we keep the historic methods around. |
…es, deleteFeature/updateFeatures
So I left |
Hi @jgravois, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've been putting out other 🔥s. this looks great.
pushed a small commit to enable updateFeatures()
to form requests correctly when services have an objectid
field with a different name.
} | ||
}] | ||
}, function (error, response) { | ||
expect(response).to.deep.equal([{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i noticed that the syntax errors i fixed in 872de35 didn't actually induce an error in your test because you're currently only introspecting the mock service response (and not the actual request parameters) which this lib actually has control over.
Great ! |
add and update several features in FeatureLayer
Add the possibility to add and update several features (
updateFeatures
,addFeatures
) by specifying a geojson featureCollection object (issue 1055)