Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent token repeating in url #1092

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Prevent token repeating in url #1092

merged 2 commits into from
Apr 24, 2018

Conversation

octavm
Copy link
Contributor

@octavm octavm commented Apr 24, 2018

Something like this? Fix for #1090

Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

that's certainly appropriate logic, but String.includes() isn't supported in IE so we'll need something a little more primitive.

@octavm
Copy link
Contributor Author

octavm commented Apr 24, 2018

Ok, thanks for the advice. What about now?

@jgravois jgravois merged commit ac117f1 into Esri:master Apr 24, 2018
@jgravois jgravois mentioned this pull request Apr 24, 2018
@octavm octavm deleted the patch-1 branch April 25, 2018 06:45
jgravois added a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Prevent token repeating in url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants