add support for Firefly Imagery Basemap #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very cool @pmacMaps!
after following the instructions here and making changes to the sourcecode, running this means that you can make a copy of debug/sample.html to quickly test things out. does that make sense? |
|
Yep, Will keep in mind for the future. |
|
thanks for this! i made one small tweak to ensure that the stock attribution is updated when users pan/zoom.
|
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
add support for Firefly Imagery Basemap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first stab at this kind of thing. Couldn't figure out how to test to make sure it works. So, don't be surprised if there are issues.
Trying to get my feet wet with contributing actual code instead of bug reports.