added warning if setTimeRange() is called without a timeField
#1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
approved these changes
May 26, 2019
| search = this._timeIndex.between(start, end); | ||
| } else { | ||
| warn('You must set a timeField to manipulate the start and end time filter.'); |
There was a problem hiding this comment.
this looks great to me. it wouldn't hurt to be even more explicit though.
'You must set timeField in the layer constructor in order to manipulate the start and end time filter'
|
after you merge i'd recommend taking a stab at shipping a patch release (to make sure you can).
npm run publish |
|
@jgravois did you mean to say |
exactly! 👮 |
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
added warning if setTimeRange() is called without a `timeField`
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
added warning if setTimeRange() is called without a `timeField`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added warning per @jgravois comment #1148 (comment). I'm not quite sure if
return [];is the correct thing to do here ... open to suggestions.