Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DynamicMapLayer.js to work with token/proxy #1164

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

crb04c
Copy link
Contributor

@crb04c crb04c commented Sep 12, 2019

Fix for DynamicLayer and token/proxy with imageData response

Fix for DynamicLayer and token/proxy with imageData response
@gavinr
Copy link
Contributor

gavinr commented Sep 12, 2019

Thanks for the contribution Chris! Is this related to a particular logged issue?

@crb04c
Copy link
Contributor Author

crb04c commented Sep 12, 2019

It's related to Issue #1153

@gavinr
Copy link
Contributor

gavinr commented Sep 12, 2019

@crb04c it looks like there are errors in the unit tests - can you check that to see if there's an issue or do the tests need to be updated? Thanks!

@crb04c
Copy link
Contributor Author

crb04c commented Sep 12, 2019

@gavinr I can take a look at the tests. My initial reaction was it was unrelated due to the location and content of the tests but I'll see if I can fix it

@jgravois
Copy link
Contributor

its very likely that if @gavinr restarts the test suite, it'll pass ✅.

@gavinr
Copy link
Contributor

gavinr commented Sep 12, 2019

Thanks @jgravois. Will try that now.

@gavinr gavinr merged commit 41f02a7 into Esri:master Sep 17, 2019
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Update DynamicMapLayer.js to work with token/proxy
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Update DynamicMapLayer.js to work with token/proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants