Add case to _featureWithinTimeRange(feature) #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a case for when the feature's time range contains the time range given in the to and from options for the layer. This way, a feature will always show up during its specified time range.
|
@pjbiogit Thank you very much for the issue logged and PR! We would like to include a unit-test update that covers your case illustrated here (I think it would go in here) - are you able to find some time to do that (feel free to just add an additional commit onto this branch/PR)? If not, one of us will try to get to it. |
Added test case for when a feature's start and end time contain the from and to times.
|
Attempted to add the test case but it seems something has gone wrong. I'm not very familiar with this so let me know if you see where I've gone wrong. |
|
no worries. its just a lint error: https://travis-ci.org/Esri/esri-leaflet/builds/609303742 |
|
thanks @pjbiogit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a case for when the feature's time range contains the time range given in the to and from options for the layer. This way, a feature will always show up during its specified time range.
#1173