Fix bugs with feature layer setWhere #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinr
reviewed
Jul 9, 2020
gavinr
approved these changes
Jul 9, 2020
Co-authored-by: Gavin Rehkemper <[email protected]>
|
This was released in v2.5.0. |
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Fix bugs with feature layer setWhere
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Fix bugs with feature layer setWhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues with
FeatureLayer.setWhere()#1196 is happening because the internal layer cache was not cleared when
setWhere()was called. #875 was caused by race conditions in callingsetWherein quick succession. Given that we cannot cancel requests we now simply ignore then if thewherein the request doesn't match the currentwhereof the layer.This means that callback to
setWherewon't be run if they get interrupted by anothersetWhere()which I think is better behavior.Adding @gavinr and @jwasilgeo for review.