Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addFeatures and updateFeatures fix #1226

Merged
merged 1 commit into from
Aug 6, 2020
Merged

addFeatures and updateFeatures fix #1226

merged 1 commit into from
Aug 6, 2020

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Aug 5, 2020

made "coords" param optional for _addFeatures() function

closes #1225

sample.html 
<!DOCTYPE html>
<html>

<head>
  <meta charset="utf-8" />
  <title>Editing feature layers</title>
  <meta name="viewport" content="initial-scale=1,maximum-scale=1,user-scalable=no" />

  <!-- Load Leaflet from CDN -->
  <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/leaflet.css"
    integrity="sha512-xwE/Az9zrjBIphAcBb3F6JVqxf46+CDLwfLMHloNu6KEQCAWi6HcDUbeOfBIptF7tcCzusKFjFw2yuvEpDL9wQ=="
    crossorigin="" />
  <script src="https://unpkg.com/[email protected]/dist/leaflet.js"
    integrity="sha512-gZwIG9x3wUXg2hdXF6+rVkLF/0Vi9U8D2Ntg4Ga5I5BZpVkVxlJWbSQtXPSiUTtC0TjtGOmxa1AJPuV0CPthew=="
    crossorigin=""></script>

  <script src="../dist/esri-leaflet-debug.js"></script>

  <!-- Load Esri Leaflet Renderers plugin to use feature service symbology -->
  <script src="https://unpkg.com/[email protected]"></script>

  <style>
    body {
      margin: 0;
      padding: 0;
    }

    #map {
      position: absolute;
      top: 0;
      bottom: 0;
      right: 0;
      left: 0;
    }
  </style>
</head>

<body>

  <!-- Leaflet Draw -->
  <style>
    #info-pane {
      position: absolute;
      top: 10px;
      right: 10px;
      z-index: 400;
      padding: 1em;
      background: white;
      text-align: right;
      max-width: 250px;
    }

    #form {
      display: none;
    }
  </style>

  <div id="map"></div>
  <div id="info-pane" class="leaflet-bar">
    <label>
      Click on the map to post an edit.<br>
      Click on a marker to remove it.
      <select id="symbols">
        <option value="Air Control Point">Air Control Point</option>
        <option value="Decision Point">Decision Point</option>
        <option value="Unmanned Aerial System (UAS UA)">Unmanned Aerial System (UAS UA)</option>
      </select>
    </label>
    <button id="setWhere1">setWhere: symbolname="Air Control Point"</button><br />
    <button id="setWhere2">setWhere: symbolname="Decision Point"</button><br />

  </div>

  <script>
    // create the map
    var map = L.map('map').setView([65, -18.5], 6);
    L.esri.basemapLayer('Physical').addTo(map);

    // add our feature layer to the map
    const militaryOps = L.esri.featureLayer({
      url: 'https://sampleserver6.arcgisonline.com/arcgis/rest/services/Military/FeatureServer/3'
    }).addTo(map);

    var symbols = document.querySelector('#symbols');

    // when the map is clicked, add a new feature
    map.on('click', function (e) {
      // convert to GeoJSON
      const feat = L.marker(e.latlng).toGeoJSON();
      // set the attribute value that controls the feature service symbology
      feat.properties.symbolname = symbols.value;
      // make a request to add the new feature to the feature service.
      militaryOps.addFeature(feat, function (err, response) {
        if (err) {
          return;
        }

        console.log(response);
      });
    });

    // when a marker is clicked, remove the feature from the service, using its id
    militaryOps.on('click', function (e) {
      militaryOps.deleteFeature(e.layer.feature.id, function (err, response) {
        if (err) {
          return;
        }

        console.log(response);
      });
      // make sure map click event isn't fired.
      L.DomEvent.stopPropagation(e);
    });

    document.getElementById('setWhere1').addEventListener('click', (evt) => {
      militaryOps.setWhere("symbolname = 'Air Control Point'");
    });

    document.getElementById('setWhere2').addEventListener('click', (evt) => {
      militaryOps.setWhere("symbolname = 'Decision Point'");
    });
  </script>

</body>

</html>

@gavinr-maps
addFeatures and updateFeatures fix
3b8f27f 
made "coords" param optional for _addFeatures() function
@gavinr gavinr requested a review from patrickarlt August 5, 2020 17:54
jwasilgeo
jwasilgeo approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@jwasilgeo jwasilgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fwiw, lgtm!)

@gavinr gavinr merged commit 508560c into master Aug 6, 2020
@gavinr gavinr deleted the 1225-setwhere-after-editing branch August 6, 2020 13:30
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
@gavinr
Merge pull request Esri#1226 from Esri/1225-setwhere-after-editing
d6d0c0f 
addFeatures and updateFeatures fix
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
@gavinr
Merge pull request Esri#1226 from Esri/1225-setwhere-after-editing
f8c89c2 
addFeatures and updateFeatures fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasilgeo jwasilgeo jwasilgeo approved these changes

@patrickarlt patrickarlt Awaiting requested review from patrickarlt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setWhere() after editing does not filter correctly
3 participants
@gavinr @jwasilgeo @gavinr-maps