-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch everything #1229
Merged
Merged
Fetch everything #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When zoomingOut, cellEnter was fired on FeatureGrid but was undefined
Fix Error on cellEnter
up ? |
any updates about including this @gavinr @patrickarlt ? |
patrickarlt
approved these changes
Oct 3, 2020
This was released in v2.5.1 - thanks! |
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
* Fix Error on cellEnter When zoomingOut, cellEnter was fired on FeatureGrid but was undefined * fix travis error (spaces) * add capability to fetch all features in a cell * fix travis, failed test and add test * merge proposal * test for geojson for isModern * support response.exceededTransferLimit or response.properties.exceededTransferLimit Co-authored-by: francois <[email protected]> Co-authored-by: François Charbonnier <[email protected]>
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
* Fix Error on cellEnter When zoomingOut, cellEnter was fired on FeatureGrid but was undefined * fix travis error (spaces) * add capability to fetch all features in a cell * fix travis, failed test and add test * merge proposal * test for geojson for isModern * support response.exceededTransferLimit or response.properties.exceededTransferLimit Co-authored-by: francois <[email protected]> Co-authored-by: François Charbonnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaned-up branch from review.
see discussion in #1206
Added support for
response.properties.exceedstransferLimit
andresponse.exceedsTransferLimit
in 2724669 (per #1206 (comment))