-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'withCredentials' option which will include credentials with CORS requests #1233
Conversation
@luiscamachopt thank you for the PR! A few small requests:
Thanks! |
980bc5d
to
aed611f
Compare
When sending cross origin requests to servers that are secured with Active Directory (issue refers to Integrated 'Windows Authentication' IWA) it is necessary to send http requests with 'withCredentials' set to true and image elements should property 'crossOrigin' set to 'use-credentials' |
when sending cross origin requests to servers that are secured with IWA/AD it is necessary to send request with 'withCredentials' set to true If the layer is created using this option the requests will be adjusted accordingly
aed611f
to
ff3f46a
Compare
Hi @gavinr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective this looks good. However this change is difficult for us to test given that:
- The original issue is old.
- The original group debugging the issue has generally moved on.
- We don't have servers readily available to test this setup.
I'm OK with merging but @gavinr can you do some extensive testing against our existing examples to ensure their are no regressions.
adjust styling for consistency Co-authored-by: Patrick Arlt <[email protected]>
Tested against all existing samples, looks ok. Merging. |
This was released in v2.5.1 - thanks! |
…CORS requests (Esri#1233) * Add support for 'withCredentials' option when sending cross origin requests to servers that are secured with IWA/AD it is necessary to send request with 'withCredentials' set to true If the layer is created using this option the requests will be adjusted accordingly * added tests for 'withCredentials' option * Apply suggestions from code review adjust styling for consistency Co-authored-by: Patrick Arlt <[email protected]> Co-authored-by: Patrick Arlt <[email protected]>
…CORS requests (Esri#1233) * Add support for 'withCredentials' option when sending cross origin requests to servers that are secured with IWA/AD it is necessary to send request with 'withCredentials' set to true If the layer is created using this option the requests will be adjusted accordingly * added tests for 'withCredentials' option * Apply suggestions from code review adjust styling for consistency Co-authored-by: Patrick Arlt <[email protected]> Co-authored-by: Patrick Arlt <[email protected]>
addresses #881