Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added deprecation notice (warning) to BasemapLayer #1293

Merged
merged 2 commits into from
Sep 24, 2021
Merged

added deprecation notice (warning) to BasemapLayer #1293

merged 2 commits into from
Sep 24, 2021

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Sep 22, 2021 •
edited
Loading

Adds a warning when using BasemapLayer:

image

This warning can be supressed/disabled by setting a new option property, ignoreDeprecationWarning, to true:

L.esri.basemapLayer("Topographic", {
  ignoreDeprecationWarning: true
}).addTo(map);

@gavinr gavinr marked this pull request as draft September 22, 2021 13:46
@alaframboise

This comment has been minimized.

Sign in to view
@gavinr gavinr marked this pull request as ready for review September 23, 2021 19:43
patrickarlt
patrickarlt approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gavinr gavinr merged commit b1e4cd3 into master Sep 24, 2021
@gavinr gavinr deleted the basemap-layer-deprecation-notice branch September 24, 2021 12:59
gavinr pushed a commit to Esri/esri-leaflet-doc that referenced this pull request Sep 24, 2021
@gavinr-maps
document new option ignoreDeprecationWarning
c0ff1ce 
Esri/esri-leaflet#1293
@gavinr gavinr mentioned this pull request Sep 24, 2021
Merged
@gavinr
Copy link
Contributor Author

gavinr commented Sep 24, 2021

This was released in v3.0.3.

jwasilgeo pushed a commit to Esri/esri-leaflet-doc that referenced this pull request Sep 24, 2021
@gavinr
document new option ignoreDeprecationWarning (#319)
e748b49 
Esri/esri-leaflet#1293
@alessandro-lenzi alessandro-lenzi mentioned this pull request Mar 7, 2022
Closed
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
@gavinr
added deprecation notice (warning) to BasemapLayer (Esri#1293)
fe86d01 
* added deprecation notice (warning) to BasemapLayer

* Update URL
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
@gavinr
added deprecation notice (warning) to BasemapLayer (Esri#1293)
4d3be63 
* added deprecation notice (warning) to BasemapLayer

* Update URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasilgeo jwasilgeo jwasilgeo approved these changes

@alaframboise alaframboise alaframboise approved these changes

@patrickarlt patrickarlt patrickarlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gavinr @alaframboise @patrickarlt @jwasilgeo @gavinr-maps