update npm release process #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when publishing, do not use "prepare" script to re-build the dist files, just use the files that are there from earlier in release.sh
|
LGTM! Does |
|
Yes, it is in the GitHub release. |
gavinr
pushed a commit
to Esri/esri-leaflet-cluster
that referenced
this pull request
Feb 25, 2022
gavinr
pushed a commit
to gavinr/esri-leaflet-geocoder
that referenced
this pull request
Feb 28, 2022
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
update npm release process
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
update npm release process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In today's builds,
siteData.jsonis still not getting published to npm.This is because we have an issue with our release process: right now,
release.shgenerates the dist files on line 8 whennpm testruns. Then later whennpm publishruns,npm prepareruns as part of that, which runsnpm run build, re-building the dist files. I think this is unnecessary and causingsiteData.jsonto not be included in the npm release.So, this PR changes it so that when publishing, do not use "prepare" script to re-build the dist files, just use the files that are there from earlier in
release.shwhen it rannpm test.