Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add special openPopup and openTooltip methods to FeatureLayer #1350

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add special openPopup and openTooltip methods to FeatureLayer #1350

merged 1 commit into from
Jan 11, 2023

Conversation

patrickarlt
Copy link
Contributor

This should fix the issue with FeatureLayer.bindPopup() and FeatureLayer.bindTooltip() introduced with Leaflet 1.9.3.

The solution was to just copy the methods but remove the logic around FeatureGroup.

RE: #1348, Leaflet/Leaflet#8761

Can be tested locally in the debug folder with:

<!DOCTYPE html>
<html>

<head>
  <meta charset="utf-8" />
  <title>Esri Leaflet Debugging Sample</title>
  <meta name="viewport" content="initial-scale=1,maximum-scale=1,user-scalable=no" />

  <link rel="stylesheet" href="https://unpkg.com/leaflet@1/dist/leaflet.css" />
  <script src="https://unpkg.com/[email protected]"></script>

  <!-- Load Esri Leaflet from source-->
  <script src="../dist/esri-leaflet-debug.js"></script>

  <style>
    body {
      margin: 0;
      padding: 0;
    }

    #map {
      position: absolute;
      top: 0;
      bottom: 0;
      right: 0;
      left: 0;
    }

    #info-pane {
      position: absolute;
      top: 10px;
      right: 10px;
      z-index: 1000;
      padding: 1em;
      background: white;
    }
  </style>
</head>

<body>
  <div id="map"></div>
  <div id="info-pane" class="leaflet-bar">
    <label>
      sample application for debugging
    </label>
  </div>

  <script>
    /*
  make a copy of this file in the same folder if you'd like git to ignore your local changes
  */
    var map = L.map("map").setView([43.5, -98.5], 6);

    L.tileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {
      attribution: '&copy; <a href="https://www.openstreetmap.org/copyright">OpenStreetMap</a> contributors'
    }).addTo(map);

    const earthquakes = L.esri
      .featureLayer({
        url: "https://sampleserver6.arcgisonline.com/arcgis/rest/services/Earthquakes_Since1970/MapServer/0"
      })
      .addTo(map);

    earthquakes.bindPopup(function (layer) {
      return L.Util.template(
        "<p>Earthquake <strong>{name}</strong> occured on {mo}/{dy}/{year_}.  It had a magnitude of {magnitude}.</p>",
        layer.feature.properties
      );
    });

    earthquakes.bindTooltip(function (layer) {
      return L.Util.template(
        "<p>{name}</p>",
        layer.feature.properties
      );
    });
  </script>
</body>

</html>

gavinr
gavinr approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@gavinr gavinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@gavinr gavinr merged commit e5fe79a into master Jan 11, 2023
@gavinr gavinr deleted the fix-1348 branch January 11, 2023 14:44
@gavinr
Copy link
Contributor

gavinr commented Jan 17, 2023

This was released in v3.0.10.

@gavinr gavinr mentioned this pull request Jan 19, 2023
Closed
@PedroVenancio PedroVenancio mentioned this pull request Jan 23, 2023
Closed
This was referenced Feb 9, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinr gavinr gavinr approved these changes

Assignees

@gavinr gavinr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickarlt @gavinr