Add removeEsriAttribution to EsriUtil export #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is needed by esri-leaflet-vector
gavinr-maps
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Note that we are already exporting setEsriAttribution() which is used by Esri Leaflet Vector. This PR is simply also exporting removeEsriAttribution - which probably should have been included back in #1248 when I added the function. But at the time I did not realize that Esri Leaflet Vector was using addEsriAttribution (and thus should also be using removeEsriAttribution).
Looks good!
|
Released in v3.0.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is needed by esri-leaflet-vector.
See details there: esri-leaflet-vector PR#208