Feature find task #287
Feature find task #287
Conversation
| return this; | ||
| }, | ||
|
|
||
| searchFields: function (searchFields) { |
There was a problem hiding this comment.
What do you think about renaming this fields to better match whats in the query the identify tasks?
There was a problem hiding this comment.
Yeah I was wondering about this. I agree we should keep the same naming convention across all the Tasks. I'll update the PR.
On the other note, what to you think about updating fields in Query/Identify to accept array or string?
There was a problem hiding this comment.
Agreed on making fields in Query/Identify accepting array or string.
|
Its probably also worth adding |
|
+1 on simplify... it makes sense. |
* Update MapService docs * Expose find task from DynamicMapLayer * Update DynamicMapLayer docs * Add example page for Finding Features under Dynamic Map Layer section * Fix few typos in docs * Add Find task specs
* Update Find task API Docs with method name changes * Add returnGeometry function to Query task and update the API docs * Add simplify method to Find task and update API docs * Update examples and fix few typos * Query fields method can now accept arrays and strings
|
Updated the PR and rebased on current master (for easier merge). |
| @@ -10,6 +10,7 @@ L.esri.Tasks.Query = L.Class.extend({ | |||
| } | |||
|
|
|||
| this._params = { | |||
| returnGeometry: true, | |||
There was a problem hiding this comment.
This is what broke all the Sinon tests. By adding an extra param the request url changed and wasn't changed in the tests to reflect this. I made a PR that fixes all this https://github.com/rdjurasaj-usgs/esri-leaflet/pull/1
Feature find task
|
I'm curious.... Are all the tests passing for you now or you're still getting the infamous |
|
👍 I hope to see one day tests passing on my computer. :) I'm officially giving up on sinon — On Sun, Jul 20, 2014 at 4:55 PM, Patrick Arlt [email protected]
|
ghost
deleted the
Feature find task
These commits are in the Public Domain. 🎉 #280