Task cors check #359
Merged
Task cors check #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
force-pushed
the
task-cors-check
branch
from
8399b7e
to
0fcc125
Compare
include resource specific CORS options for Tasks fixed linting fixed linting
jgravois
force-pushed
the
task-cors-check
branch
from
9026f13
to
d23eb73
Compare
|
@jgravois this looks good. Can you add some tests for this. You could look at https://github.com/Esri/esri-leaflet/blob/master/spec/Services/ServiceSpec.js as a reference. |
|
yup. i'm having trouble running grunt locally at the moment (hangs on 'watch' task), but i'll get it figured out and lay down another commit with the appropriate tests. realizing a couple more things though
|
|
@patrickarlt these tests seem appropriate to me (and are passing). let me know what you think. |
|
not sure whats going on here. all tests are passing in my local branch... |
|
Let me kick off a new build and see how that does. Shouldn't be an error there. |
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Task cors check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced logic in base Task class to allow users to define CORS support in constructor based on the capability of the hosting web server.
Follows same pattern as base Service class.
if this approach is okay, i will follow up and update documentation.