Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added deleteFeatures methods #510

Merged
merged 3 commits into from
Apr 28, 2015
Merged

Conversation

jgravois
Copy link
Contributor

i've added a couple methods so that clients can pass an array of objectIds in a single request to the server.

map.on('draw:deleted', function(e) {
    var delArray = [];
    e.layers.eachLayer(function(layer) {
      var id = layer.feature.id;
      delArray.push(id);
    });
    pedestrianDistricts.deleteFeatures(delArray, function(error, response) {
      console.log(error, response);
    });
});

to do:

  • - write tests
  • - update our sample app to use the new method (via be45fb6)
  • - update the doc

@patrickarlt
Copy link
Contributor

@jgravois looks like the tests are doing their usual failures for unrelated reasons. Could you finish this up today? I could fix the tests (again) and do a release tomorrow.

@jgravois jgravois changed the title added deleteFeatures methods [not ready] added deleteFeatures methods Apr 28, 2015
@jgravois
Copy link
Contributor Author

ok. ready to merge now. im going to wait until we tag to update the editing sample to use the new method. (i can bump the CDN tagged versions in all the samples at the same time).

@patrickarlt
Copy link
Contributor

@jgravois let me do a release first and make sure everything is up to date. Then I want to switch to jsdelivr.com CDN where ever we can.

patrickarlt added a commit that referenced this pull request Apr 28, 2015
@patrickarlt patrickarlt merged commit e0c5fd2 into Esri:master Apr 28, 2015
@jgravois
Copy link
Contributor Author

👍

jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants