Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to loading a blank png when a tile request fails #784

Merged
merged 1 commit into from
Jun 17, 2016

Conversation

jgravois
Copy link
Contributor

resolves #759

it seems sensible to me that we just load a transparent .png by default when individual tile requests return a 404 error and easiest to just grab it directly from the Esri knowledge base article i tracked down.

Article ID: 36939
http://support.esri.com/en/knowledgebase/techarticles/detail/36939

@jgravois jgravois merged commit 0eb1fda into master Jun 17, 2016
@jgravois jgravois deleted the broken-thumbnails branch June 17, 2016 19:21
@blq
Copy link

blq commented Dec 8, 2016

I notice that this blank tile png is hosted on a plain http url.
Would it be possible for you to host it on https instead? A site that uses https for maps will otherwise block it and get lots of mixed content warnings!

@jgravois
Copy link
Contributor Author

jgravois commented Dec 8, 2016

Would it be possible for you to host it on https instead?

thats a good idea. the current resource doesn't support encrypted requests so i'll have to think a bit about where else to store the .png.

@blq
Copy link

blq commented Dec 8, 2016

OK. or use an inline base64 image?

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAQAAAAEABAMAAACuXLVVAAAAA1BMVEUzNDVszlHHAAAAAXRSTlMAQObYZgAAAAlwSFlzAAAAAAAAAAAB6mUWpAAAADZJREFUeJztwQEBAAAAgiD/r25IQAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA7waBAAABw08RwAAAAABJRU5ErkJggg==

(the above is exact blank256.png encoded, but I haven't tested live)

@patrickarlt
Copy link
Contributor

@jgravois what @blq would suffice pretty nicely without having to host an additional resource.

jgravois added a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
default to loading a blank png when a tile request fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken thumbnails with tile layers
3 participants