fire appropriate feature events when entire featureLayer is toggled #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readd, not recreate why
|
@jgravois with this PR calling setWhere results in firing the addfeature event twice. |
|
thanks for the repro case. please open a new issue for this to help us track the bug report. |
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
…sri#790) readd, not recreate why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #788
previously the
addfeatureandremovefeatureevents were specific to situations in which an individual feature was appended or dropped from the collection associated with a layer that was currently being drawn (typically because of panning and zooming).this change extends the logic to fire
removefeatureevents for individual features when the entire layer is removed from the map.for consistency, i also ensured that
addfeaturefires both when a featureLayer is added to the map initially, and again after it is toggled back on.cc/ @denydias