Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honor leaflet maxNativeZoom #904

Merged
merged 2 commits into from
Dec 29, 2016
Merged

honor leaflet maxNativeZoom #904

merged 2 commits into from
Dec 29, 2016

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Dec 20, 2016

resolves #743

@patrickarlt was right. i just had to make sure and update the logic down in createTile() too.

@chriserickson
Copy link

chriserickson commented Dec 20, 2016

Just glancing at the patch, did you want to default back to point.z with no lodmap, or default back to the zoom level as the comment states?

eg

(this._lodMap && this._lodMap[this._getZoomForUrl()]) ? 
  this._lodMap[this._getZoomForUrl()] : this._getZoomForUrl()

// instead of
(this._lodMap && this._lodMap[this._getZoomForUrl()]) ? 
  this._lodMap[this._getZoomForUrl()] : tilePoint.z

@jgravois
Copy link
Contributor Author

good catch! with no lodmap, we should default back to the zoom level.

@chriserickson
Copy link

I manually hacked this in to our esri-leaflet-src, and it appears to work.

@jgravois
Copy link
Contributor Author

travis will show green here as soon as #906 is merged and the build is restarted.

@jgravois jgravois merged commit a18b692 into Esri:master Dec 29, 2016
@ahalota
Copy link

ahalota commented Sep 11, 2017

Should this be working now? I am linking to the file shown on the main page for cdn (https://unpkg.com/[email protected]/dist/esri-leaflet-debug.js) but still not getting native zoom respected. Which version of leaflet did you have this working with?

@jgravois
Copy link
Contributor Author

hi @ahalota! the fix was included in v2.0.7 and continues to resolve the original repro case.

  1. launch https://jsfiddle.net/jagravois/z7mjvgvm/
  2. whether you toggle the esri layer or the native leaflet layer, both start to resample at zoom 16.

if you have more information or can provide a demo of your own i'd be happy to take another look.

@jgravois jgravois deleted the patch743 branch September 12, 2017 02:05
@ahalota
Copy link

ahalota commented Sep 14, 2017

Never mind. It was an odd issue in my ArcServer that was not allowing me to access the higher resolution images and turning up transparent tiles instead...

jgravois added a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiles disappear when zooming beyond 'maxNativeZoom'
3 participants