Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setOpacity on RasterLayers #909

Merged
merged 1 commit into from
Jan 4, 2017
Merged

setOpacity on RasterLayers #909

merged 1 commit into from
Jan 4, 2017

Conversation

Saulzi
Copy link
Contributor

@Saulzi Saulzi commented Jan 3, 2017

fix for
#908

@jgravois
Copy link
Contributor

jgravois commented Jan 3, 2017

thanks for this!

i noticed that the commit here is actually associated with @mrsaulzi, likely because the email address in your git config --global user.email is different than the one associated with github.com/Saulzi.

New commits aren't using the right name
https://help.github.com/articles/setting-your-username-in-git/#new-commits-arent-using-the-right-name

i'm certainly happy to accept as is, but if you want to tidy things up so that Saulzi appears in perpetuity as the 🎪 50th 🎉 esri leaflet contributor, please don't be shy.

(i only mention it because i did exactly the same thing a long time ago)

@Saulzi
Copy link
Contributor Author

Saulzi commented Jan 4, 2017

I have deleted the mrsaulzi account and added / set email address on this account. does it now appear correctly?

@jgravois
Copy link
Contributor

jgravois commented Jan 4, 2017

does it now appear correctly?

yup. now the commit avatar and pull request avatar are the same. thanks again for this fix!

@jgravois jgravois merged commit 4f62c77 into Esri:master Jan 4, 2017
nonZero added a commit to nonZero/esri-leaflet that referenced this pull request Apr 26, 2017
jgravois added a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants