reverse simplification scale and ensure bindPopup simplifies output geometry #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch applies a simplification factor of 0.5 to output geometries in bindPopup using the current scale of the map to ensure that no more vertices than necessary are retrieved from the server. for the test case provided by the user, this reduced the payload from 213kb/600ms to 922b/150ms without visible evidence on screen when zoomed out far on a complex feature
|
in testing this change i noticed that the simplification scale for i've added another commit here to ensure that |
jgravois
changed the title
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
reverse simplification scale and ensure bindPopup simplifies output geometry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #919 (partially anyway)
this patch applies a simplification factor of 0.5 to output geometries in dynamicMapLayer.bindPopup using the current scale of the map to ensure that no more vertices than necessary are retrieved from the server.
for the test case provided by the user, this reduced the payload from
213kb/600msto922b/150mswhen zoomed out pretty far on a complex feature.i think this is a sensible default so that we can ensure in more cases that the map click interaction is snappy.