Add check for layer visibility when cellEnter is called. #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very cool! it looks like either the email or username in your local git config doesn't match what you're using for your github account. its not crucial, but if you want to take the time to clean it up the commit in the PR will be associated correctly.
|
|
Ok, thanks. I figured I was bound to mess something up. I think I fixed it. Let me know if it looks good on your end. |
i'm just making sure the avatar in the thread matches the avatar for the commit. looks great! as for the code fix, i'm in the middle of something at the moment, but i'll be able to review more fully (and hopefully write a few tests) soon. thanks for the contribution! |
|
Great, thanks. |
|
thanks again for the contribution! |
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Feb 18, 2017
* upstream/master: dont check for _map, nullify the variable dont query outside FeatureLayer visible scale (Esri#928) Add check for layer visibility when cellEnter is called. (Esri#924) not sure i'll ever stop doing that make sure 1 means more simplified bindPopup should simplify output geometry slightly this patch applies a simplification factor of 0.5 to output geometries in bindPopup using the current scale of the map to ensure that no more vertices than necessary are retrieved from the server.
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
* Add check for layer visibility when cellEnter is called. * Add check for layer visibility when cellEnter is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a layer that is visible at say zoom 16 - 20 and then zoom out to 15 the layer will not be visible (as expected). If you then pan out of the current virtual grid bounds and then pan back to your original position the layer becomes visible even though you are still at zoom 15.
This is fixed by checking for visibleZoom within cellEnter so features are only added to the map if in a visible zoom.