Fix content type for ImageMapLayer #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default server response content type per the [docs](http://esri.github.io/esri-leaflet/api-reference/layers/image-map-layer.html#options) for an `imageMapLayer` should be `image`, not `json`.
|
Here's a working example where the default |
|
thanks for this @nickpeihl! you have any interest in helping me reopen the can of worms in #952? |
|
I should have searched before submitting the PR. I didn't know it was previously discussed. Let me dig in a bit and see where I can help. |
|
no need to apologize. having 'imageMapLayer' fetching raw images is an improvement in my book and a good first step toward doing the same with 'dynamicMapLayer'. i seem to remember the other change being error inducing in the test suite, but between the two of us, i'm sure we'll be able to figure it out. |
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Fix content type for ImageMapLayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default server response content type per the docs for an
imageMapLayershould beimage, notjson.