This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Fix issues with outer rings not containing holes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2014
jgravois
added a commit
that referenced
this pull request
Mar 16, 2016
Fix issues with outer rings not containing holes
|
pulled down locally and confirmed tests are passing. thanks from 2016 @patrickarlt! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of trying to fix Esri/esri-leaflet#320. Under certain conditions it is possible for outer rings to not always contain holes.
The solution is to check again to see if the hole intersects an outer ring after checking contains against every outer ring.
If a ring neither intersects another ring or is contained inside it it will be turned into an outer ring.