(REVIEW ONLY) Jeremy bubble exercises #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to the Ethereal Engine developer community! We require contributors to sign our Copyright Assignment Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the agreement at https://forms.gle/15ENsSAJGKf2ozvB7 The agreement has not been signed by users: @Rezmason. After signing the agreement, you can ask me to recheck this PR by posting |
DanielBelmes
approved these changes
Dec 14, 2023
| @@ -92,21 +93,31 @@ export const BubbleEmitterComponent = defineComponent({ | |||
| // Spawning a single bubble as an example | |||
| // [Exercise 1]: Using this system. Spawn multiple bubbles with varying x,z Localtransform positons | |||
| // [Exercise 3]: Remove them if they are too old(bubble.age > N seconds)[This can be done in a couple ways(reactively and within this sytem synchronosly)] | |||
| if(emitterComponent.bubbleEntities.value!.length < 1) { //For example ensuring there is only one bubble being added | |||
| const bubbles: Array<Entity> = [] | |||
There was a problem hiding this comment.
using emitterComponent.bubbleEntities was enough to track the bubbles.
| if(emitterComponent.bubbleEntities.value!.length < 1) { //For example ensuring there is only one bubble being added | ||
| const bubbles: Array<Entity> = [] | ||
| const numExistingBubbles = emitterComponent.bubbleEntities.value!.length | ||
| const numBubbles = 10 |
There was a problem hiding this comment.
I'd prefer this constant to actually be at the top of the file or configured withing the emitter component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge! But feedback appreciated. Things of note:
bubblesarray getting populated and then merged the right approach?.slice()necessary to guarantee iterator stability? ie., do we routinely look out for mutating data structures we're in the middle of looping over?