Skip to content

[BUG] Fix if_else series naming from predicate broadcast #4505

[BUG] Fix if_else series naming from predicate broadcast

[BUG] Fix if_else series naming from predicate broadcast #4505

Triggered via pull request March 29, 2024 18:52
Status Success
Total duration 23s
Artifacts

release-drafter.yml

on: pull_request
update_release_draft
5s
update_release_draft
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
update_release_draft
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"} { name: 'HttpError', id: '8484476660', status: 422, response: { url: 'https://api.github.com/repos/Eventual-Inc/Daft/releases/147572246', status: 422, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-length': '195', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Fri, 29 Mar 2024 18:53:03 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'GitHub.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'contents=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': 'F81F:111FA4:77621B:C4CC5F:66070E0E', 'x-ratelimit-limit': '5000', 'x-ratelimit-remaining': '4984', 'x-ratelimit-reset': '1711741930', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '16', 'x-xss-protection': '0' }, data: { message: 'Validation Failed', errors: [ { resource: 'Release', code: 'invalid', field: 'target_commitish' } ], documentation_url: 'https://docs.github.com/rest/releases/releases#update-a-release' } }, request: { method: 'PATCH', url: 'https://api.github.com/repos/Eventual-Inc/Daft/releases/147572246', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/16.20.2 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"body":"## Changes\\n\\n## ✨ New Features\\n\\n- [FEAT] round expression implemtation @sherlockbeard (#2041)\\n- [FEAT] Add str.extract\\\\_all expression @colin-ho (#2038)\\n- [FEAT] Add str.right() function @murex971 (#2031)\\n- [FEAT] Sign expression implemtation @sherlockbeard (#2037)\\n- [FEAT] drop psutil in favor of our own tool @samster25 (#2035)\\n- [FEAT] Allow passing on\\\\_error=\\"null\\" to ignore decoding errors in image decode @jaychia (#2033)\\n- [FEAT] Add str.extract() function @colin-ho (#2020)\\n- [FEAT] Add str.left() funtion @murex971 (#2027)\\n\\n## 🚀 Performance Improvements\\n\\n- [PERF] [Delta Lake] Add IO multithreading arg to `daft.read_delta_lake()`. @clarkzinzow (#2029)\\n\\n## 👾 Bug Fixes\\n\\n- [BUG] enable dependabot for iceberg int tests @samster25 (#2042)\\n- [BUG] Fix all-null ImageArray length issues @jaychia (#2034)\\n\\n## 📖 Documentation\\n\\n- [FEAT] Add str.extract\\\\_all expression @colin-ho (#2038)\\n- [FEAT] Add str.extract() function @colin-ho (#2020)\\n- [CHORE] Add global aggregation docs and error on improper aggregation usage @kevinzwang (#2025)\\n\\n## 🧰 Maintenance\\n\\n- [CHORE] Remove autouse from gen\\\\_tpch fixture @colin-ho (#2049)\\n- [CHORE] Refactor sql tpch tests @colin-ho (#2047)\\n- [CHORE] Add tpch test for read sql @colin-ho (#2026)\\n- [CHORE] Add column range stats from read\\\\_sql @colin-ho (#2015)\\n- [CHORE] upgrade upload/download artifact github action @samster25 (#2043)\\n- [CHORE] Exclude Twitter and LinkedIn from broken link checker @colin-ho (#2030)\\n- [CHORE] Add global aggregation docs and error on improper aggregation usage @kevinzwang (#2025)\\n\\n## ⬆️ Dependencies\\n\\n<details>\\n<summary>4 changes</summary>\\n\\n- Bump lxml from 4.9.3 to 5.1.0 @dependabot (#1764)\\n- Bum
update_release_draft
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"} at /home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:8462:21 at processTicksAndRejections (node:internal/process/task_queues:96:5) at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:30793:18) { name: 'AggregateError', event: { id: '8484476660', name: 'pull_request', payload: { action: 'edited', changes: { body: { from: 'When predicate is broadcasted in the if_else kernel and the predicate is false, the if_false series is cloned and the name is left as is, which causes a \r\n' + '```\r\n' + 'ValueError: DaftError::ComputeError Mismatch of expected expression name and name from computed series\r\n' + '```\r\n' + 'at expression evaluation time because the expected field name is the [if_true series name. ](https://github.com/Eventual-Inc/Daft/blob/main/src/daft-dsl/src/expr.rs#L530)\r\n' + '\r\n' + 'Example code to reproduce:\r\n' + '```\r\n' + 'df = daft.from_pydict({"predicate": [False], "if_true": ["true"], "if_false": ["false"]})\r\n' + 'df = df.select((df["predicate"] == True).if_else(df["if_true"], df["if_false"]))\r\n' + 'df.show()\r\n' + '```' } }, number: 2051, organization: { avatar_url: 'https://avatars.githubusercontent.com/u/98941975?v=4', description: 'Eventual Computing', events_url: 'https://api.github.com/orgs/Eventual-Inc/events', hooks_url: 'https://api.github.com/orgs/Eventual-Inc/hooks', id: 98941975, issues_url: 'https://api.github.com/orgs/Eventual-Inc/issues', login: 'Eventual-Inc', members_url: 'https://api.github.com/orgs/Eventual-Inc/members{/member}', node_id: 'O_kgDOBeW8Fw', public_members_url: 'https://api.github.com/orgs/Eventual-Inc/public_members{/member}', repos_url: 'https://api.github.com/orgs/Eventual-Inc/repos', url: 'https://api.github.com/orgs/Eventual-Inc' }, pull_request: { _links: { comments: { href: 'https://api.github.com/repos/Eventual-Inc/Daft/issues/2051/comments' }, commits: { href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/2051/commits' }, html: { href: 'https://github.com/Eventual-Inc/Daft/pull/2051' }, issue: { href: 'https://api.github.com/repos/Eventual-Inc/Daft/issues/2051' }, review_comment: { href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/comments{/number}' }, review_comments: { href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/2051/comments' }, self: { href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/2051' }, statuses: { href: 'https://api.github.com/repos/Eventual-Inc/Daft/statuses/f8d766fb6e924ebe08d8fa268ce503f9761336fb' } }, active_lock_reason: null, additions: 27, assignee: null, assignees: [], author_association: 'CONTRIBUTOR', auto_merge: null, base: { label: 'Eventual-Inc:main', ref: 'main', repo: { allow_auto_merge: true, allow_forking: true, allow_merge_commit: false, allow_rebase_merge: false, allow_squash_merge: true, allow_update_branch: false, archive_url: 'https://api.github.com/repos/Eventual-Inc/Daft/{archive_format}{/ref}', archived: false, assignees_url: 'https://api.github.com/repos/Eventual-Inc/Daft/assignees{/user}', blobs_url: 'https://api.github.com/repos/Eventual-Inc/Daft/git/blobs{/sha}', branches_url: 'https://api.github.com/repos/Eventual
update_release_draft
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: release-drafter/release-drafter@v5. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.