Skip to content

Commit

Permalink
Properly use config values in planner
Browse files Browse the repository at this point in the history
  • Loading branch information
Jay Chia committed Dec 5, 2023
1 parent 84ffb29 commit 4def95c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/common/daft-config/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#[derive(Clone)]
pub struct DaftConfig {
merge_scan_tasks_min_size_bytes: usize,
merge_scan_tasks_max_size_bytes: usize,
pub merge_scan_tasks_min_size_bytes: usize,
pub merge_scan_tasks_max_size_bytes: usize,
}

impl Default for DaftConfig {
Expand Down
4 changes: 2 additions & 2 deletions src/daft-plan/src/planner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ pub fn plan(logical_plan: &LogicalPlan, cfg: Arc<DaftConfig>) -> DaftResult<Phys
// Apply transformations on the ScanTasks to optimize
let scan_tasks = daft_scan::scan_task_iters::merge_by_sizes(
scan_tasks,
64 * 1024 * 1024,
512 * 1024 * 1024,
cfg.merge_scan_tasks_min_size_bytes,
cfg.merge_scan_tasks_max_size_bytes,
);

let scan_tasks = scan_tasks.collect::<DaftResult<Vec<_>>>()?;
Expand Down

0 comments on commit 4def95c

Please sign in to comment.