[CHORE] Implementations of FixedSizeListArray #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaychia
force-pushed
the
jay/fsl-array-impl
branch
from
931758a
to
39d36a8
Compare
jaychia
force-pushed
the
jay/fsl-array-impl
branch
4 times, most recently
from
5c7487a
to
dc366c0
Compare
added 8 commits
August 25, 2023 17:26
Implement SeriesLike for logical fixed size list arrays using same macro Refactor image.rs to remove len() from DaftArrayType trait impl SeriesLike for FixedSizeListArray Cleanup matching logic -- match on ALL Daft types Bugfix: logical serieslike rename
impl cast, rename, to_arrow impl full_null, if_else, to_arrow impl cast from FixedSizeList to FixedShapeImage impl take and slice Switch impl of FixedSizeListArray to always assume padded child impl concat impl filter impl broadcast impl DaftCountAggable impl is_null impl repr Fix nested guard for Series::try_from arrow2 arrays Switch to using arrow2::bitmap::Bitmap for validity Fix FSL->FSL cast More as_arrow cleanups, excluding image.rs
Fixes to finally compile
jaychia
changed the title
jaychia
force-pushed
the
jay/fsl-array-impl
branch
from
4b89cd3
to
7527029
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
===========================================
+ Coverage 74.09% 87.33% +13.23%
===========================================
Files 61 61
Lines 6038 6038
===========================================
+ Hits 4474 5273 +799
+ Misses 1564 765 -799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces our old arrow-backed
FixedSizeListArray = DataArray<FixedSizeListType>with a newFixedSizeListArraystruct.In so doing, many changes were required:
FixedSizeListArraywhich is our own struct. Now,FixedSizeListType::ArrayType = FixedSizeListArray.FixedSizeListGrowable.LogicalArrayswhich rely onFixedSizeListArrayas their physical type::PhysicalType = FixedSizeListTypeLogicalArrayImpl<L, FixedSizeListArray>matching.rsthat matches the new semantics forFixedSizeList(i.e. it is not longer an arrow type)with_match_daft_typesmatch statement that matches all possible DataTypes, which we use liberally when implementing nested functionality.cast.rscount,filter,from_arrow,full,get,if_else,image.rs,len.rs,list.rs,list_agg.rs,null.rsetc