Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [New Query Planner] Refactor file globbing logic by exposing FileInfos to Python #1307

Merged
merged 1 commit into from
Aug 30, 2023

Unify file globbing logic by exposing FileInfos to Python.

7d6985d
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] [New Query Planner] Refactor file globbing logic by exposing FileInfos to Python #1307

Unify file globbing logic by exposing FileInfos to Python.
7d6985d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2023 in 1s

87.31% (-0.04%) compared to e15aa27

View this Pull Request on Codecov

87.31% (-0.04%) compared to e15aa27

Details

Codecov Report

Merging #1307 (7d6985d) into main (e15aa27) will decrease coverage by 0.04%.
The diff coverage is 98.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   87.34%   87.31%   -0.04%     
==========================================
  Files          61       61              
  Lines        6039     6016      -23     
==========================================
- Hits         5275     5253      -22     
+ Misses        764      763       -1     
Files Changed Coverage Δ
daft/execution/physical_plan_factory.py 91.52% <ø> (ø)
daft/execution/rust_physical_plan_shim.py 98.21% <ø> (-0.07%) ⬇️
daft/logical/builder.py 78.57% <ø> (ø)
daft/logical/optimizer.py 97.92% <ø> (ø)
daft/logical/logical_plan.py 79.42% <80.00%> (-0.07%) ⬇️
daft/execution/execution_step.py 93.62% <100.00%> (-0.04%) ⬇️
daft/execution/physical_plan.py 94.58% <100.00%> (+0.01%) ⬆️
daft/filesystem.py 86.58% <100.00%> (+0.33%) ⬆️
daft/io/common.py 95.00% <100.00%> (+0.88%) ⬆️
daft/io/file_path.py 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes