[CHORE] Add Series::full_null/empty/from_arrow to reduce code duplication #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaychia
changed the title
jaychia
force-pushed
the
jay/series-generic-functions
branch
from
d088958
to
ebce448
Compare
jaychia
force-pushed
the
jay/growable-factory
branch
from
905620a
to
8432e14
Compare
jaychia
force-pushed
the
jay/series-generic-functions
branch
from
ebce448
to
d1d4e1c
Compare
jaychia
force-pushed
the
jay/growable-factory
branch
2 times, most recently
from
cea063d
to
17174dc
Compare
jaychia
force-pushed
the
jay/series-generic-functions
branch
2 times, most recently
from
edca504
to
2c00389
Compare
jaychia
force-pushed
the
jay/series-generic-functions
branch
from
2c00389
to
7e620af
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
=======================================
Coverage ? 87.28%
=======================================
Files ? 61
Lines ? 6000
Branches ? 0
=======================================
Hits ? 5237
Misses ? 763
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
with_match_daft_types!in a bunch of places that really should just be delegated to theSeriesinstead.This PR centralizes that logic under dedicated methods on
Series::full_null/empty/from_arrowwhich account for most of the usage ofwith_match_daft_types!outside of specific places that still require it (make_growableandrepr)