Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] factor io config into common code #1335

Merged
merged 3 commits into from
Sep 2, 2023
Merged

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Sep 1, 2023

  • Factors out IOConfig, S3Config, etc into a common io-config crate.
  • Reexports them in the daft-io crate for convenience
  • sadly daft-dsl still depends on daft-io for the url_download function so we still have to recompile quite a bit.
  • This should be fixed when we allow for dynamic function registration.

@github-actions github-actions bot added the chore label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1335 (a8b6ee7) into main (6fc90da) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files          61       61           
  Lines        6000     6000           
=======================================
  Hits         5237     5237           
  Misses        763      763           

@samster25 samster25 merged commit 00647a8 into main Sep 2, 2023
29 checks passed
@samster25 samster25 deleted the sammy/factor-out-io-config branch September 2, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant