Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Native S3 Client: allow disabling ssl verification or checking hostnames #1395

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Sep 20, 2023

  • adds verify_ssl and check_hostname_ssl options for S3Config, which allows the user to disable verification steps for Tls connections.

@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2023
@samster25 samster25 changed the title [FEAT] allow disabling ssl verification or checking hostnames [FEAT] Native S3 Client: allow disabling ssl verification or checking hostnames Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1395 (8997ed1) into main (1efeb33) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
- Coverage   87.81%   87.79%   -0.02%     
==========================================
  Files          60       60              
  Lines        6031     6031              
==========================================
- Hits         5296     5295       -1     
- Misses        735      736       +1     

see 1 file with indirect coverage changes

@samster25 samster25 merged commit 83b73b2 into main Sep 21, 2023
31 checks passed
@samster25 samster25 deleted the sammy/native-s3-disable-host-check-flag branch September 21, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant