Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Docs] Allow source code discovery to fail silently for pyo3-defined classes when generating docs. #1430

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[BUG] [Docs] Allow source code discovery to fail silently for pyo3-defined classes when generating docs. #1430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions daft/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@
from_pylist,
from_ray_dataset,
)
from daft.daft import ImageFormat, ResourceRequest
from daft.daft import ImageFormat, ImageMode, ResourceRequest

Check warning on line 73 in daft/__init__.py

View check run for this annotation

Codecov / codecov/patch

daft/__init__.py#L73 

Added line #L73 was not covered by tests
from daft.dataframe import DataFrame
from daft.datatype import DataType, ImageMode, TimeUnit
from daft.datatype import DataType, TimeUnit

Check warning on line 75 in daft/__init__.py

View check run for this annotation

Codecov / codecov/patch

daft/__init__.py#L75 

Added line #L75 was not covered by tests
from daft.expressions import col, lit
from daft.io import from_glob_path, read_csv, read_json, read_parquet
from daft.series import Series
Expand Down
2 changes: 1 addition & 1 deletion docs/source/api_docs/datatype_image_mode/daft.ImageMode.from_mode_string.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

.. currentmodule:: daft

.. automethod:: ImageMode.from_mode_string
.. automethod:: ImageMode.from_mode_string
2 changes: 1 addition & 1 deletion docs/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def linkcode_resolve(domain, info):
try:
file = inspect.getsourcefile(obj)
lines = inspect.getsourcelines(obj)
except TypeError:
except (TypeError, OSError):
# e.g. object is a typing.Union
return None
path_start = file.find("daft/")
Expand Down
Loading