Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix runner check at plan execution time for new query planner #1435

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Sep 25, 2023

This PR fixes is_ray_runner check at plan execution time in the new query planner. Previously, we were checking the Daft context at execution time, which wouldn't be properly set under the Ray runner, since we don't propagate the Daft context to all Ray workers. This PR changes the runner check to be based on an explicit flag passed from the runner to the physical plan execution API.

Closes #1433

@github-actions github-actions bot added the bug Something isn't working label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1435 (8d6067b) into main (ecb596a) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
- Coverage   74.51%   74.51%   -0.01%     
==========================================
  Files          60       60              
  Lines        6035     6034       -1     
==========================================
- Hits         4497     4496       -1     
  Misses       1538     1538              
Files Coverage Δ
daft/execution/rust_physical_plan_shim.py 98.18% <100.00%> (-0.04%) ⬇️
daft/planner/planner.py 87.50% <100.00%> (ø)
daft/planner/rust_planner.py 100.00% <100.00%> (ø)
daft/runners/pyrunner.py 95.80% <100.00%> (ø)
daft/runners/ray_runner.py 91.20% <100.00%> (ø)
daft/planner/py_planner.py 0.00% <0.00%> (ø)

@clarkzinzow clarkzinzow merged commit f45f523 into main Sep 25, 2023
26 checks passed
@clarkzinzow clarkzinzow deleted the clark/fix-new-query-planner-ray-runner branch September 25, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] New query planner breaking in remote ray execution
2 participants