[BUG] Fix num input partitions in coalesce. #1442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the number of input partitions in our
Coalesce
implementation. The new query planner was incorrectly using the current logical node'snum_partitions
for the number of input partitions, which for aCoalesce
op, is equal to the output number of partitions; we should instead be using the input (child) logical node'snum_partitions
.The microbenchmarking failure also illustrated that we didn't have any unit testing coverage of
Coalesce
(i.e.df.into_partitions(n)
wheren
is smaller than the current number of partitions), so we also add a sanity unit test.Closes #1434