Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix num input partitions in coalesce. #1442

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Sep 25, 2023

This PR fixes the number of input partitions in our Coalesce implementation. The new query planner was incorrectly using the current logical node's num_partitions for the number of input partitions, which for a Coalesce op, is equal to the output number of partitions; we should instead be using the input (child) logical node's num_partitions.

The microbenchmarking failure also illustrated that we didn't have any unit testing coverage of Coalesce (i.e. df.into_partitions(n) where n is smaller than the current number of partitions), so we also add a sanity unit test.

Closes #1434

@github-actions github-actions bot added the bug Something isn't working label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1442 (a88976e) into main (ecb596a) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage   74.51%   74.61%   +0.09%     
==========================================
  Files          60       60              
  Lines        6035     6035              
==========================================
+ Hits         4497     4503       +6     
+ Misses       1538     1532       -6     

see 2 files with indirect coverage changes

@clarkzinzow clarkzinzow merged commit 97845d3 into main Sep 25, 2023
26 checks passed
@clarkzinzow clarkzinzow deleted the clark/fix-coalesce branch September 25, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Microbenchmarks are hanging
3 participants