[FEAT] Add local native filesystem globbing. #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkzinzow
commented
Sep 26, 2023
clarkzinzow
commented
Sep 26, 2023
src/daft-io/src/local.rs
Outdated
| path: path.to_string_lossy(), | ||
| const LOCAL_PROTOCOL: &str = "file://"; | ||
| let path = uri.strip_prefix(LOCAL_PROTOCOL).unwrap_or(uri); | ||
| let meta = tokio::fs::metadata(path) |
There was a problem hiding this comment.
Changed to top-level tokio::fs::metadata() which (1) will follow symlinks, and (2) I believe has less overhead than opening + fetching the metadata off of the file object.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
+ Coverage 74.61% 74.62% +0.01%
==========================================
Files 60 60
Lines 6034 6034
==========================================
+ Hits 4502 4503 +1
+ Misses 1532 1531 -1 |
samster25
reviewed
Sep 27, 2023
|
@clarkzinzow Can we also add some python tests and ensure we have the same behavior as s3 and gcs? |
samster25
reviewed
Sep 28, 2023
samster25
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
lsimplementation for the native local filesystem.Closes #1441