Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixes globbing on windows by consolidating on posix-style paths #1472

Merged
merged 7 commits into from
Oct 7, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 6, 2023

Addresses part of #1466 which is currently failing because of globbing in windows on: #1467

@github-actions github-actions bot added the bug Something isn't working label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #1472 (5ccf791) into main (cdbcec4) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1472   +/-   ##
=======================================
  Coverage   74.64%   74.64%           
=======================================
  Files          60       60           
  Lines        6042     6042           
=======================================
  Hits         4510     4510           
  Misses       1532     1532           

see 1 file with indirect coverage changes

@jaychia jaychia merged commit 78fcfff into main Oct 7, 2023
24 checks passed
@jaychia jaychia deleted the jay/consolidate-glob-delimiter branch October 7, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant