Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Don't remove all handles and Only use handler for files in src/ #1473

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

samster25
Copy link
Member

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1473 (b14cf7d) into main (cdbcec4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   74.64%   74.64%           
=======================================
  Files          60       60           
  Lines        6042     6043    +1     
=======================================
+ Hits         4510     4511    +1     
  Misses       1532     1532           
Files Coverage Δ
daft/logging.py 92.59% <100.00%> (+0.28%) ⬆️

@samster25 samster25 marked this pull request as ready for review October 6, 2023 21:55
@samster25 samster25 changed the title [BUG] Sammy/daft logger fix [BUG] Don't remove all handles and Only use handler for files in src/ Oct 6, 2023
@samster25 samster25 merged commit 4dd1e8d into main Oct 6, 2023
26 checks passed
@samster25 samster25 deleted the sammy/daft-logger-fix branch October 6, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant