Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] IOStats for Native Reader #1493

Merged
merged 7 commits into from
Oct 16, 2023
Merged

[FEAT] IOStats for Native Reader #1493

merged 7 commits into from
Oct 16, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Oct 13, 2023

  • Implements IOStats via atomics that will track the number of:
  • GetRequests
  • HeadRequests
  • ListRequests
  • BytesRead

When the IOStatsContext goes out of scope it will debug log its output:
For a parquet read:

IOStatsContext: read_parquet: for uri s3://eventual-dev-benchmarking-fixtures/parquet-benchmarking/tpch/200MB-2RG/daft_200MB_lineitem_chunk.RG-2.parquet, Gets: 17, Heads: 1, Lists: 0, BytesRead: 213627535, AvgGetSize: 12566325

For our io_glob:

IOStatsContext: io_glob for s3://daft-segment-data/segment-logs/**, Gets: 0, Heads: 0, Lists: 237, BytesRead: 0, AvgGetSize: 0

Currently the context is threaded through our python Apis for io_glob, read_parquet, and read_csv

IOStats is currently implemented for:

  • S3
  • GCS
  • HTTP
  • Azure

@samster25 samster25 changed the title Sammy/io stats [Feat] IOStats for Native Reader Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #1493 (8f765b5) into main (e1e5eaf) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   74.97%   74.96%   -0.02%     
==========================================
  Files          60       60              
  Lines        6123     6123              
==========================================
- Hits         4591     4590       -1     
- Misses       1532     1533       +1     

see 1 file with indirect coverage changes

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@samster25 samster25 changed the title [Feat] IOStats for Native Reader [FEAT] IOStats for Native Reader Oct 16, 2023
@github-actions github-actions bot added the enhancement New feature or request label Oct 16, 2023
@samster25 samster25 merged commit bf5b598 into main Oct 16, 2023
25 of 26 checks passed
@samster25 samster25 deleted the sammy/io-stats branch October 16, 2023 04:58
@samster25
Copy link
Member Author

closes: #1456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IO Statistics] Return IO statistics for methods in daft-parquet
2 participants