Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Better logging for physical plan #1499

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 17, 2023

  1. Reduces the verbosity of physical planner debug logs by logging only the number of partitions rather than printing the partition itself
  2. Adds a setup_debug_logging function for convenience when performing local/dogfooding

@github-actions github-actions bot added the chore label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1499 (0a48456) into main (9d20890) will decrease coverage by 0.15%.
Report is 2 commits behind head on main.
The diff coverage is 7.69%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   74.87%   74.73%   -0.15%     
==========================================
  Files          59       60       +1     
  Lines        6106     6118      +12     
==========================================
  Hits         4572     4572              
- Misses       1534     1546      +12     
Files Coverage Δ
daft/execution/execution_step.py 92.82% <ø> (ø)
daft/runners/pyrunner.py 95.83% <100.00%> (ø)
daft/logging.py 0.00% <0.00%> (ø)

@jaychia jaychia merged commit bdd2128 into main Oct 17, 2023
23 of 24 checks passed
@jaychia jaychia deleted the jay/physical-plan-logging branch October 17, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant